Story/vspc 232 214 215 multiple languages #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # vspace/src/main/java/edu/asu/diging/vspace/core/factory/ISpaceFactory.java # vspace/src/test/java/edu/asu/diging/vspace/config/ExhibitionLanguageConfigTest.java
|
Make it so, Jenkins. |
6 similar comments
|
Make it so, Jenkins. |
|
Make it so, Jenkins. |
|
Make it so, Jenkins. |
|
Make it so, Jenkins. |
|
Make it so, Jenkins. |
|
Make it so, Jenkins. |
|
|
There are test failures |
pooja-thalur
reviewed
Nov 6, 2024
| <groupId>log4j</groupId> | ||
| <artifactId>log4j</artifactId> | ||
| <version>1.2.15</version> | ||
| <groupId>org.apache.logging.log4j</groupId> |
There was a problem hiding this comment.
made this change to resolve codefactor issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
This pull request combines 3 stories
VSPC-232 - It should be possible to specify about text in multiple languages
VSPC-214 - If there are multiple languages specified for an exhibition, the user should be able to enter text for a slide in each language.
VSPC-215 - If there are multiple languages defined for an exhibition, staff users should be able to specify space title and descriptions for each language.
Anything else the reviewer needs to know?
Upgraded log4j to resolve this codefactor issue - Use of vulnerable log4j:log4j