Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests update #14

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Tests update #14

merged 2 commits into from
Jun 2, 2021

Conversation

vbuberen
Copy link
Contributor

@vbuberen vbuberen commented Jun 2, 2021

This PR updates tests to be less flaky, fixes some typos and adds a new changelog entry.

After my previous PR merge I saw that tests failed https://github.com/dinko-pehar/mock_data/runs/2619656817
In logs we can see that it was due to one of mockLocation tests having some conditions which aren't really guaranteed to always get the same result. So I fixed it.

Along with that I found a few small typos in tests names, etc.

@dinko-pehar Could you also let me know if you plan to release a null-safety update to pub.dev? Would be good to have it sort of officially available to projects, like the one I am currently working on.

@dinkopehar
Copy link
Owner

Hey @vbuberen

Thank you again for contributing. Yeah, I saw some tests failed but didnt find time to explore mockLocation since it isn't a feature I created.
I will try to release it tomorrow I hope.
Has everything set up for v2 by the looks of it ?

@dinkopehar dinkopehar added the enhancement New feature or request label Jun 2, 2021
@vbuberen
Copy link
Contributor Author

vbuberen commented Jun 2, 2021

I don't really know about your roadmap, but I think that yes, everything is ready for v2, since the main reason for major version bump is null safety migration.

I would improve tests as you suggested in #7, but it can be done later as not really influences the package at the moment.

@dinkopehar dinkopehar merged commit 383cef3 into dinkopehar:master Jun 2, 2021
@dinkopehar
Copy link
Owner

Tests pass and it's merged into master . I'll release this tomorrow and notify you here.

@dinkopehar
Copy link
Owner

dinkopehar commented Jun 3, 2021

@vbuberen It's released 🎉 🚀
Thank you for your help and for using it in first place. If you have any questions, feel free to ask.

@vbuberen
Copy link
Contributor Author

vbuberen commented Jun 3, 2021

Thank you as well for creating it in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants