Document Redis SSL configs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😞 oh |
carltongibson
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Thanks for this @bbrowning918 👍
(I need to look at what happened to the CI...)
This was referenced Sep 4, 2023
justuswilhelm
added a commit
to jwpconsulting/projectify
that referenced
this pull request
Sep 8, 2023
justuswilhelm
added a commit
to jwpconsulting/projectify
that referenced
this pull request
Sep 8, 2023
|
May I suggest that there could be a typo in the README as it is right now? (not mentioning the missing restructured text code block) Right now it says something like the following, which is not a valid dict. I reverted to using my own helper for now. It's too bad testing deployments on Heroku is so time consuming. |
|
@justuswilhelm In hindsight I did not do a great job 'copy-pasting' our config from memory. Thank you for noticing that and the rst syntax mistake. |
|
I tweaked it, but happy to take any improvements. |
justuswilhelm
added a commit
to jwpconsulting/projectify
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is ongoing discussion and help in #235 and #330 (are there more?) about how to specify extra config for the connections to Redis, particularly SSL related.
The example provided is how we got Heroku to behave with it's self-signed certs on 4.1.0. Hopefully it will be helpful and answer a common question.