Add close margin position endpoint #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fatiudeen Rework your PR |
|
@djeck1432 it was from merging main to resolve conflict. The first commit has the work done |
djeck1432
requested changes
Feb 26, 2025
margin_app/Dockerfile
Outdated
| @@ -8,11 +8,11 @@ ENV PYTHONDONTWRITEBYTECODE 1 | |||
| # Set PATH for Poetry | |||
| ENV PATH "/root/.local/bin:$PATH" | |||
|
|
|||
| # Add system-level dependencies (including gcc and npm) | |||
| # Add system-level dependencies (including gcc and PostgreSQL client) | |||
There was a problem hiding this comment.
why did you make changes here?
margin_app/scripts/entrypoint.sh
Outdated
|
|
||
| # Wait for PostgreSQL to be ready | ||
| echo "Waiting for PostgreSQL..." | ||
| while ! pg_isready -h db -p 5432 -U "${POSTGRES_USER}" >/dev/null 2>&1; do |
fatiudeen
force-pushed
the
feat/close-margin-position-endpoint
branch
from
7b38f88 to
d46eba2
Compare
|
@djeck1432 all merge changes have been reverted |
Fix issue with removing extra param
|
Please, resolve merge conflict and I will merge it |
…/close-margin-position-endpoint
…com/fatiudeen/spotnet into feat/close-margin-position-endpoint
|
@djeck1432 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close issue - #645