Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes made #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enyinnaya1234
Copy link
Contributor

fix-#685

@whateverfw whateverfw self-requested a review March 1, 2025 19:03
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you clearly see that build files are in project, right?
saying in 3rd time - fix build correctly.

@djeck1432
Copy link
Owner

@enyinnaya1234 Hi, do you have any updates?

@djeck1432 djeck1432 self-requested a review March 3, 2025 12:10
@djeck1432
Copy link
Owner

@enyinnaya1234 if you have any issue please, let us know,thank you

@enyinnaya1234
Copy link
Contributor Author

my major challenge is getting rid of the .js and .d.ts files from the PR sir. Honestly i have been on it since yesterday, but one way or the other have been unable to get a solution..

@djeck1432

@whateverfw
Copy link
Collaborator

@enyinnaya1234 can't you just create a branch new branch from main and only apply necessary changes there, so .js and d.ts files are not built&commited, rather end up in gitignored /dist folder..
What exactly goes wrong, could you describe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants