feat: [MarginFrontend] Fix linter & build #694
+11,218
−2,780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djeck1432 pls review. |
whateverfw
requested changes
Mar 2, 2025
There was a problem hiding this comment.
again, that's incorrect. build files should not be commited as a part of root folder..
It is fine that you gitignored /dist, however
I don't want to see .js and d.ts files in your PR.
You should make sure that everything is built into that folder and not commited outside.
|
@djeck1432 , pls review boss |
whateverfw
requested changes
Mar 3, 2025
Comment on lines
+190
to
+203
| /**/*.js | ||
| /**/*.js.map | ||
| /**/*.d.ts | ||
|
|
||
| # But don't ignore JavaScript in specific places | ||
| !/webpack.config.js | ||
| !/jest.config.js | ||
| # (add any other JS files that should be kept) | ||
|
|
||
| # Keep the dist folder ignored | ||
| /dist | ||
|
|
||
| # TypeScript incremental compilation cache | ||
| *.tsbuildinfo |
Comment on lines
+207
to
+216
| *.js | ||
| *.d.ts | ||
| *.js.map | ||
| *.d.ts.map | ||
| /components/*.js | ||
| /components/*.d.ts | ||
| /components/*.js.map | ||
| # Except specific JS files that should be committed | ||
| !vite.config.js | ||
| !vitest.config.js |
There was a problem hiding this comment.
no, you should never do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add build folder to git ignore
close-#685