[Margin] Add ekubo swap method #695
Open
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faurdent
requested changes
Mar 2, 2025
There was a problem hiding this comment.
You also miss the composite type with data required for the swap(PoolKey, slippage limits and price for this pool, we are collecting this data on the backend). We will pass it to functions that utilize swap functionality to keep everything swap-related in one place.
| treasury_balances: Map<(ContractAddress, ContractAddress), TokenAmount>, | ||
| pools: Map<ContractAddress, TokenAmount>, | ||
| positions: Map<ContractAddress, Position>, | ||
| } | ||
|
|
||
|
|
||
| #[generate_trait] | ||
| impl InternalImpl of InternalTrait { |
There was a problem hiding this comment.
You also need to implement Locker trait which will contain the swap logic
|
|
||
|
|
||
| #[derive(Copy, Drop, Serde)] | ||
| pub struct SwapResult { |
There was a problem hiding this comment.
I don't know if we need it there as we will only return Delta. You can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.