Make unpredictableSeed use CryptGenRandom (CryptoAPI) on Windows
#10624
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10624" |
0xEAB
force-pushed
the
unpredictable-seed-loss32
branch
5 times, most recently
from
a3b6342 to
499bfa0
Compare
0xEAB
force-pushed
the
unpredictable-seed-loss32
branch
4 times, most recently
from
20c2a61 to
345d936
Compare
0xEAB
commented
Jan 19, 2025
std/random.d
Outdated
Comment on lines
1782
to
1789
| import core.sys.windows.wincrypt : | ||
| CryptAcquireContext, | ||
| CryptGenRandom, | ||
| CryptReleaseContext, | ||
| CRYPT_VERIFYCONTEXT, | ||
| MS_STRONG_PROV, | ||
| PROV_RSA_FULL; |
There was a problem hiding this comment.
Blame D-Scanner for this monstrosity :)
0xEAB
force-pushed
the
unpredictable-seed-loss32
branch
from
345d936 to
9a3cdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
unpredictableSeedto callCryptGenRandomon Windows.Analogous to #10623 (Linux).
On the one hand, the legacy CryptoAPI might be deprecated, on the other hand using it does not introduce a new DLL dependency.
advapi32is already required bystd.registryand Phobos is linked against as seen in the currentMakefile.Using the more modern CNG (
BCryptGenRandom) would not only introduce a new dependency, but also require us to add the corresponding bindings to druntime. I figured that wouldn’t be worth the effort for now.