Fix ConcurrentModificationException when shutting down async listeners #3169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a copy of the list before iterating over it so that ConcurrentModificationException isn't thrown
For example the FastLogin plugin calls
unregisterAsyncHandlers
like this in their onDisabled methodwhich resulted in this error before the fix
On thing that bothers me though is the
: null
part of the exception. Is this the correct fix? I don't know, but it works¯\_(ツ)_/¯