Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 3.11 beta builds too #86

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 7, 2025

👀 https://www.pypy.org/posts/2025/02/pypy-v7318-release.html

(still considered "beta", so I've left "3" and "latest" pointing to 3.10)

@tianon
Copy link
Member Author

tianon commented Feb 7, 2025

hylang/hy#2631 😅

I guess we should be more particular about that test for PyPy 🤔

@tianon
Copy link
Member Author

tianon commented Feb 7, 2025

I've dug into this a little more, and opened docker-library/official-images#18403 to bump this test to newer Hy, which doesn't fix this issue, but is good*.

I'm adding an asterisk there because the more I look at it, the more I no longer think this test actually makes sense for us to keep. Originally it was helpful as a deeper test of Python, but I don't think it's caught us any Python bugs, and just puts us at the forefront of Hy integration problems like this one.

"But Tianon," you might say, "isn't that a good thing?" Yes! Yes, it is. HOWEVER, we literally have the https://hub.docker.com/_/hylang image which would run into these same integration issues, but in a more appropriate place (such that they're only affecting updates to the Hy image, not PyPy or Python).

So in short, I think we should actually perhaps remove that test instead, as much as I love it and find it extremely cute, since we'll keep it anyways on all the variants of the Hy image (but without that hairy if statement for filtering supported versions, because it'll only even run for supported versions, pre-filtered).

Edit:

@tianon
Copy link
Member Author

tianon commented Feb 11, 2025

Close+reopen to regenerate tests so they pick up docker-library/official-images#18418

@tianon
Copy link
Member Author

tianon commented Feb 11, 2025

Traceback (most recent call last):
  File "/tmp/test-dir/python-sqlite3/container.py", line 1, in <module>
    import sqlite3
  File "/opt/pypy/lib/pypy3.11/sqlite3/__init__.py", line 57, in <module>
    from sqlite3.dbapi2 import *
  File "/opt/pypy/lib/pypy3.11/sqlite3/dbapi2.py", line 27, in <module>
    from _sqlite3 import *
  File "/opt/pypy/lib/pypy3.11/_sqlite3.py", line 57, in <module>
    from _sqlite3_cffi import ffi as _ffi, lib as _lib
ImportError: /opt/pypy/lib/pypy3.11/_sqlite3_cffi.pypy311-pp73-x86_64-linux-gnu.so: undefined symbol: sqlite3_deserialize
	'python-sqlite3' [7/8]...failed

if it's not one thing, it's another...

@tianon
Copy link
Member Author

tianon commented Feb 11, 2025

Oh, that's probably that these new 3.11 builds don't/can't support the sqlite in bullseye anymore, so we need to drop bullseye from 3.11+, I think.

@tianon
Copy link
Member Author

tianon commented Feb 11, 2025

That means #87 is kind of important here, but it's fine for them to be separate. 😄

@tianon
Copy link
Member Author

tianon commented Feb 11, 2025

Ok, now failures are just the weird GHA infra issue we've been seeing across Windows Server 2025 builds.

@tianon tianon merged commit 6d1cce0 into docker-library:master Feb 12, 2025
18 of 21 checks passed
@tianon tianon deleted the 3.11 branch February 12, 2025 01:05
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 12, 2025
Changes:

- docker-library/pypy@6d1cce0: Merge pull request docker-library/pypy#86 from infosiftr/3.11
- docker-library/pypy@a1c6fd6: Add the 3.11 beta builds too
@tianon
Copy link
Member Author

tianon commented Feb 12, 2025

Ok, now failures are just the weird GHA infra issue we've been seeing across Windows Server 2025 builds.

docker-library/official-images#18435 (comment):

The problem is that the windows-2025 runner is too old to run the mcr.microsoft.com/windows/servercore:ltsc2025 image released this week (actions/runner-images#11582). It should be fine for our builds since we pin to specific Windows images and can delay moving the 2025 pin until the GitHub runners are ready. This will mean that the Windows 2025 images will not get their "Patch Tuesday" rebuilds until the runner images are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant