Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests #130

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Update unit tests #130

merged 2 commits into from
Jan 6, 2024

Conversation

bsweeney
Copy link
Member

@bsweeney bsweeney commented Jan 1, 2024

  • move fonts to tests resources directory
  • remove Intel Clear-Light
  • add W3C unit test font Ahem
  • add new font info test

@bsweeney
Update unit tests
eaa3c9a 
- move fonts to tests resources directory
- remove Intel Clear-Light
- add W3C unit test font Ahem
- add new font info test

fixes #117
@bsweeney bsweeney linked an issue Jan 1, 2024 that may be closed by this pull request
New test #117
Closed
@bsweeney bsweeney mentioned this pull request Jan 1, 2024
Closed
williamdes
williamdes approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice !

@williamdes
Copy link
Contributor

This backports my fix in some way: https://sources.debian.org/src/php-font-lib/0.5.4+dfsg-3/debian/patches/0002-Update-tests-to-add-more-assertions-and-use-fonts-no.patch/

I am quite glad that I can drop it in Debian

@williamdes
Copy link
Contributor

Could you also apply the other ones ?
https://udd.debian.org/patches.cgi?src=php-font-lib&version=0.5.4%2Bdfsg-3

@bsweeney
Copy link
Member Author

bsweeney commented Jan 5, 2024

Is there anything else to do?

  • 0001-lintian-national-encoding.patch is no longer necessary since the autoloader was removed.
  • 0003-Adapt-for-phpunit-10.patch also not necessary? At least, the one change that was required (removing the syntaxCheck configuration attribute) was already addressed in PR Update .gitattributes and remove bower.json + .htaccess #125.

@williamdes
Copy link
Contributor

Indeed, seems like everything is handled 🎉 Nothing more to do then.

Should SECURITY.md be gitattributes removed ?

@bsweeney
Copy link
Member Author

bsweeney commented Jan 6, 2024 •
edited
Loading

I don't feel strongly either way on that one. We do remove it from Dompdf, though, so I guess for the sake of consistency it will be done.

@bsweeney @williamdes
Update tests/FontLib/FontTest.php
8aec068 
Co-authored-by: William Desportes <[email protected]>
@bsweeney bsweeney added this to the 0.5.5 milestone Jan 6, 2024
@bsweeney bsweeney merged commit 41489fb into master Jan 6, 2024
13 checks passed
@bsweeney bsweeney deleted the test-updates branch January 6, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.

New test
2 participants
@bsweeney @williamdes