Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: add kanagawa theme #790

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

theme: add kanagawa theme #790

wants to merge 13 commits into from

Conversation

Anskrevy
Copy link

@Anskrevy Anskrevy commented Jun 6, 2023

This theme is based on rebelot's theme by the same name. I've never written a theme before and still pretty new to using emacs so please let me know if I've missed something/something doesn't look right.

Fixes #0000
References #0000
Replaces #0000

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

Screenshots

pic-window-230605-1804-21
pic-window-230605-1807-22

gagbo
gagbo suggested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@gagbo gagbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Still not sure when it's going to get merged, but there are a few things you can change meanwhile to help the PR :)

README.md Outdated Show resolved Hide resolved
themes/doom-kanagawa-theme.el Outdated Show resolved Hide resolved
@hlissner hlissner added the is:theme Requests that a theme be added or removed label Sep 6, 2023
@hlissner hlissner added this to the v2.4.0 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagbo gagbo gagbo requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is:theme Requests that a theme be added or removed
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Anskrevy @gagbo @hlissner @johndovern