Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apollo-usage-report): wait for hashing schema before preparing the report #3647

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jan 14, 2025

Wait for setting schemaId to prevent race condition, previously it wasn't waiting so sometimes at the beginning, Misformed trace, missing operation key or schema id was thrown

@ardatan ardatan requested a review from EmrysMyrddin January 14, 2025 09:59
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: cf3fb38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-apollo-usage-report Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Jan 14, 2025

💻 Website Preview

The latest changes are available as preview in: https://246e249b.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Jan 14, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 517310      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  693 kB/s
     http_req_blocked.............................: avg=1.59µs   min=1.06µs   med=1.36µs   max=5.59ms   p(90)=2.04µs   p(95)=2.24µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=133.95µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=360.3µs  min=218.69µs med=326.75µs max=15.16ms  p(90)=475.89µs p(95)=498.66µs
       { expected_response:true }.................: avg=360.3µs  min=218.69µs med=326.75µs max=15.16ms  p(90)=475.89µs p(95)=498.66µs
     ✓ { mode:graphql-jit }.......................: avg=287.41µs min=218.69µs med=270.03µs max=15.16ms  p(90)=301.23µs p(95)=317.37µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=503.57µs min=414.67µs med=478.13µs max=6.3ms    p(90)=522.1µs  p(95)=627.11µs
     ✓ { mode:graphql-response-cache }............: avg=344.09µs min=263.96µs med=327.39µs max=6.59ms   p(90)=357.34µs p(95)=368.25µs
     ✓ { mode:graphql }...........................: avg=366.72µs min=279.66µs med=337.21µs max=13.87ms  p(90)=400.78µs p(95)=449.82µs
     ✓ { mode:uws }...............................: avg=340.66µs min=269.91µs med=323.79µs max=6.39ms   p(90)=357.47µs p(95)=377.47µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 258655
     http_req_receiving...........................: avg=33.3µs   min=16.16µs  med=32.9µs   max=2.79ms   p(90)=39.56µs  p(95)=42.09µs 
     http_req_sending.............................: avg=8.85µs   min=5.83µs   med=7.82µs   max=309.62µs p(90)=11.18µs  p(95)=12.39µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=318.14µs min=184.06µs med=285.62µs max=15.05ms  p(90)=433.14µs p(95)=454.34µs
     http_reqs....................................: 258655  1724.350854/s
     iteration_duration...........................: avg=574.84µs min=395.99µs med=537.27µs max=15.76ms  p(90)=693.9µs  p(95)=720.94µs
     iterations...................................: 258655  1724.350854/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant