-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jwt/introspection): ability to disable introspection based on JWT result #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff3243e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://e48d5158.graphql-yoga.pages.dev |
✅ Benchmark Results
|
ardatan
requested review from
dotansimha,
n1ru4l,
EmrysMyrddin and
enisdenjo
and removed request for
dotansimha
January 17, 2025 14:50
enisdenjo
previously requested changes
Jan 17, 2025
ardatan
force-pushed
the
introsection-disable-via-jwt
branch
from
January 18, 2025 01:16
d4dca2b
to
ff3243e
Compare
dotansimha
approved these changes
Jan 20, 2025
enisdenjo
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3614 so you can combine JWT plugin with introspection plugin in this case.
The following changes are needed;
JWT Plugin changes;
Ensure the JWT context has been added before any GraphQL Execution hooks when the plugin is used via Yoga
Introspection plugin changes;
Expose the server context as the second parameter, so introspection can be disabled based on the
context