Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] Strip arity from Cecil imported generic types. #450

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jul 19, 2019

One of the issues trying to bind the BouncyCastle .jar in #424 is that we write generic types with invalid signatures, like:

public List`1<string> MyProperty { get; set; }

This is how a Cecil type reference FullName is returned. Since this notation is not useful to us, this PR strips the arity while reading the assembly.

This results in the proper type syntax:

public List<string> MyProperty { get; set; }

@jpobst jpobst changed the title [generator] Strip arity from Cecil imported types. [generator] Strip arity from Cecil imported generic types. Jul 19, 2019
@jonpryor jonpryor merged commit 262743b into master Jul 19, 2019
@jpobst jpobst deleted the strip-arity branch July 19, 2019 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants