JIT: Add 3-opt stress mode #111640
Merged
JIT: Add 3-opt stress mode #111640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
amanasifkhalid
commented
Jan 21, 2025
| fgDoReversePostOrderLayout(); | ||
| fgMoveColdBlocks(); | ||
| // Skip preliminary reordering passes to create more work for 3-opt layout | ||
| if (compStressCompile(STRESS_THREE_OPT_LAYOUT, 10)) |
There was a problem hiding this comment.
I picked this frequency arbitrarily, though I suppose it doesn't have to be too high since this stress mode will always kick in for JitStress=2. I'm open to suggestions here.
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. No diffs. Thanks! |
AndyAyersMS
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this stress mode is enabled, skip the preliminary reordering passes -- RPO layout and cold code motion -- to create more work for 3-opt, thus exercising new cut points. We could probably do something more aggressive, like reverse the initial layout order (though we'd need to respect EH invariants), but this was enough to help me repro some failures like #111347 locally.