[RISC-V] Use zero register as argument for atomics #112693
Open
+141
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tomeksowi
commented
Feb 19, 2025
| // Return Value: | ||
| // Whether the floating-point immediate can be synthesized with one instruction | ||
| // | ||
| static bool isSingleInstructionFpImm(double value, emitAttr size, int64_t* outBits) |
There was a problem hiding this comment.
68730b3 is being scheduled for building and testingGIT: |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sirntar
approved these changes
Feb 20, 2025
clamp03
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A zero constant was unnecessarily synthesized, wasting a register.
Also fix a non-obvious bug in CompareExchange with unextended comparand register (see added test case).
Part of #84834, cc @dotnet/samsung