Fix HttpHandlerDiagnosticListenerTests.TestW3CHeadersTraceStateAndCorrelationContext #112753
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@antonfirsov the issue #112426 is opened against .NET 8.0. This PR will force closing the issue which will make the failure still show in .NET 8 builds. Will you port this fix to 8.0 and possibly 9.0? CC @noahfalk |
tarekgh
approved these changes
Feb 20, 2025
Sure, thanks for the heads-up! |
This was referenced Feb 20, 2025
antonfirsov
commented
Feb 21, 2025
| @@ -145,6 +145,7 @@ public async Task TestBasicReceiveAndResponseEvents() | |||
| } | |||
| } | |||
|
|
|||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/112792")] | |||
There was a problem hiding this comment.
I almost missed that this test is also failing. It seems to be a product bug, disabling for now. cc @tarekgh in case you have concerns.
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me how did this test pass before, but given it's testing W3C tracestate format behavior on .NET Framework,
ActivityIdFormat.W3Cshould be explicitly set asDefaultIdFormatin the test. This will ensure that theRequest-Idheader (that is specific to the Hierarchical format) will be absent, making the last Assert pass.Fixes #112426