New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The weather plugin is broken: revert the latest changes to make it functional again #305

Merged

ethancedwards8 merged 2 commits into dracula:master from fvincenzo:master

Oct 19, 2024

Contributor

fvincenzo commented Oct 18, 2024

The weather plugin:

On Mac: reports empty results because the default bash is stack to version 3 and seems not cooping with the changes reverted
On Linux: it work but reports the wrong location

Propose to revert the changes to make it working again.

fvincenzo added 2 commits

October 18, 2024 19:26


          Revert "exported bash functions so that we can add timeout"

6c431a1

This reverts commit a3398ad.


          Revert "added timeout to the weather_wrapper.sh script"

4c37751

This reverts commit 66e3b0a.

ethancedwards8 merged commit fead19a into dracula:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet