Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Generic system temperature support #307

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

locnnil
Copy link
Contributor

@locnnil locnnil commented Oct 19, 2024

* Complements dracula#149
* Use lm-sensors package to read temperature
* Detect raspberry Pi and keep using vcgencmd in case.

Signed-off-by: Lincoln Wallace <[email protected]>
scripts/dracula.sh Outdated Show resolved Hide resolved
Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
Copy link
Contributor

@fvincenzo fvincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch. Thanks!

Just few nits from me.

README.md Outdated Show resolved Hide resolved
scripts/dracula.sh Outdated Show resolved Hide resolved
scripts/sys_temp.sh Outdated Show resolved Hide resolved
Signed-off-by: Lincoln Wallace <[email protected]>
@locnnil
Copy link
Contributor Author

locnnil commented Oct 21, 2024

@fvincenzo and @ethancedwards8 thank you very much for your reviews, I appreciate it! This is now ready to be reviewed again.

@ethancedwards8 ethancedwards8 merged commit ea1a45d into dracula:master Oct 21, 2024
1 check passed
@ethancedwards8
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants