Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build action environment variable #3

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix build action environment variable #3

merged 1 commit into from
Jan 12, 2024

Conversation

chrisjkuch
Copy link
Collaborator

For reasons, loading secrets in the environment section of the build action leads to null values being populated. This is probably fixable in other ways, but the login server URL is not a secret since we use it to host the image, so this is probably the easiest / most straightforward fix.

@chrisjkuch chrisjkuch requested a review from r-b-g-b January 12, 2024 18:30
@chrisjkuch chrisjkuch merged commit 9241f65 into main Jan 12, 2024
2 checks passed
@chrisjkuch chrisjkuch deleted the fix-action-env branch January 31, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-b-g-b r-b-g-b r-b-g-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisjkuch @r-b-g-b