fix: escaping to git ref in path not working #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch. I feel like there may be one more bug fix needed. Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly. I'm not sure if / how this would manifest into a bug, but it would be great to do some more research on this and maybe get some unit tests for the different scenarios. cc @d1wilko @tphoney |
|
Can this bug be fixed? |
|
@chamhaw this needs to be addressed before we can get this merged
I think it is a simple order of operations issue. trim before you encode and that probably resolves the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems an inadvertent mistake for escaping.