Pass namespace through to attribute metadata #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hmm, I found the tests in the gentests dir. AFAICT they test that just fine, which let me to an error in my test data. |
LudmilaSamalova
pushed a commit
to Deutsche-Boerse/go-xml
that referenced
this pull request
Jan 2, 2020
Pass namespace through to attribute metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address #80
It seemed to do the right thing on my WSDL files, but I'm not 100% certain the behaviour is perfect.
I've updated the test cases and generated code to match the new output, but I don't know if it's correct.