-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the "setup" command for Docker installation via SSH #6
Open
jorgecar
wants to merge
30
commits into
trunk
Choose a base branch
from
5-implement-setup-command-for-docker-installation-via-ssh
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement the "setup" command for Docker installation via SSH #6
jorgecar
wants to merge
30
commits into
trunk
from
5-implement-setup-command-for-docker-installation-via-ssh
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to write a message to the Console from anywhere in the application.
This trait has the logic to run any script on a remote server via SSH. I put it separately because it is where the connection to the remote server is defined, and in case of errors, the code is totally isolated.
This new method is used to get the first server too.
This way I avoid having to define the same constructor in all commands to inject the manifest.
- withOutput: this method active the stream output for the processes - docker: is a shortcut for execute docker cli
Accepts a boolean parameter stream to know if the stream has to be written to the console.
The Command Output is an OutputStyle object which is more sophisticated than the ConsoleOutput object. It also avoids the magic of bind the output object on the service provider.
It is required to declarate the withOutput method for all the Process objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #5 by implementing the "setup" command, which acquires a server lock to prevent concurrent operations and facilitates the installation of Docker via SSH.
Changes Made
Testing done