Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phishing Detection Data Update Script #3243

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

not-a-rootkit
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204023833050360/1208270234071172/f
Tech Design URL: https://app.asana.com/0/481882893211075/1207483114414814
CC:

Description:
In ✓ Tech Design: Phishing Protection Data Updates we defined an approach to get embedded data for phishing protection into the app builds. This pattern was implemented, but two small components still need merging:
The update script:
A small bash script that pulls data from the API into the repo in JSON format, and updates the checksums + revision values in PhishingDetection.swift .
This has already been implemented, it just needs testing and merging:

A GitHub Action workflow that executes this script once a week and creates a PR that merges this data into the new release build.
Example Script
The secrets and workflow have already been defined, it just needs to be tested and merged.

Steps to test this PR:

  1. Execute bash scripts/update_phishing_detection_data.sh
  2. Ensure it succeeds
  3. Check git, validate that the version has been updated to a higher version, and SHA hashes were updated in ./DuckDuckGo/PhishingDetection/PhishingDetection.swift

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 895a14a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant