Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add filterlist subfeature to ios & android overrides #2659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dharb
Copy link
Collaborator

@dharb dharb commented Jan 16, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1208811874906681/f

Description

This PR adds the filterlist subfeature to autoconsent, which will be used to test the changes from duckduckgo/autoconsent#592 on iOS & Android. There will be no user facing changes when we enable this subfeature at first, we will just be injecting a new larger autoconsent bundle without turning the filterlists on to confirm that it doesn't cause any issues in production. Once we're confident that is the case, we'll update the iOS & Android code to enable the filterlist feature.

Feature change process:

Reference

@dharb dharb added the DO NOT MERGE Don't merge this branch unless directed label Jan 16, 2025
@dharb dharb requested review from a team as code owners January 16, 2025 23:21
@dharb dharb requested a review from tomasstrba January 16, 2025 23:21
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 16, 2025

Generated file outputs:

Time updated: Fri, 17 Jan 2025 20:47:10 GMT

legacy
trackers-unprotected-temporary.txt (12 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json (1 more)
  • v3/android-config.json
  • v3/ios-config.json
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -992,8 +992,11 @@
                                 "percent": 100
                             }
                         ]
                     }
+                },
+                "filterlist": {
+                    "state": "disabled"
                 }
             }
         },
         "autofillBreakageReporter": {
latest
v4/android-config.json (1 more)
  • v4/android-config.json
  • v4/ios-config.json
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -820,8 +820,11 @@
                                 "percent": 100
                             }
                         ]
                     }
+                },
+                "filterlist": {
+                    "state": "disabled"
                 }
             }
         },
         "autofillBreakageReporter": {
v4/extension-brave-config.json (11 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

@@ -358,6 +358,9 @@
}
]
}
},
"filterlist": {
"state": "disabled"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update to add minSupportedVersion and flip to enabled once it's confirmed which version this is going out in.

@@ -170,6 +170,9 @@
}
]
}
},
"filterlist": {
"state": "disabled"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update to add minSupportedVersion and flip to enabled once it's confirmed which version this is going out in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant