-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add filterlist subfeature to ios & android overrides #2659
base: main
Are you sure you want to change the base?
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Fri, 17 Jan 2025 20:47:10 GMT legacytrackers-unprotected-temporary.txt (12 more)
v3/android-config.json (1 more)
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -992,8 +992,11 @@
"percent": 100
}
]
}
+ },
+ "filterlist": {
+ "state": "disabled"
}
}
},
"autofillBreakageReporter": {
latestv4/android-config.json (1 more)
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -820,8 +820,11 @@
"percent": 100
}
]
}
+ },
+ "filterlist": {
+ "state": "disabled"
}
}
},
"autofillBreakageReporter": {
v4/extension-brave-config.json (11 more)
|
@@ -358,6 +358,9 @@ | |||
} | |||
] | |||
} | |||
}, | |||
"filterlist": { | |||
"state": "disabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to add minSupportedVersion
and flip to enabled once it's confirmed which version this is going out in.
@@ -170,6 +170,9 @@ | |||
} | |||
] | |||
} | |||
}, | |||
"filterlist": { | |||
"state": "disabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to add minSupportedVersion
and flip to enabled once it's confirmed which version this is going out in.
Asana Task/Github Issue: https://app.asana.com/0/0/1208811874906681/f
Description
This PR adds the
filterlist
subfeature to autoconsent, which will be used to test the changes from duckduckgo/autoconsent#592 on iOS & Android. There will be no user facing changes when we enable this subfeature at first, we will just be injecting a new larger autoconsent bundle without turning the filterlists on to confirm that it doesn't cause any issues in production. Once we're confident that is the case, we'll update the iOS & Android code to enable the filterlist feature.Feature change process:
Tech design: https://app.asana.com/0/481882893211075/1209010810078878/f
Reference