Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/linux: update warn files #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

dvyukov
Copy link
Owner

@dvyukov dvyukov commented Jan 11, 2022

Regenerate warn files on the latest kernel commit fe8152b38d3
and latest syzkaller commit with fresh kernel config files.


Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md


We generate slightly reduces configs for arm/arm64 b/c we test in slow qemu VMs.
Add full versions of these configs that can be used with syz-check to avoid
no-such-struct warnings.
@dvyukov dvyukov force-pushed the dvyukov-syz-check-update branch from e79a11e to e0503ea Compare January 11, 2022 19:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #1 (a1d1645) into master (44d1319) will increase coverage by 0.0%.
The diff coverage is 80.0%.

Impacted Files Coverage Δ
pkg/symbolizer/nm.go 76.2% <80.0%> (+20.4%) ⬆️
prog/any.go 84.5% <0.0%> (+1.0%) ⬆️
prog/hints.go 92.5% <0.0%> (+1.9%) ⬆️

@dvyukov dvyukov force-pushed the dvyukov-syz-check-update branch 5 times, most recently from 4d3406a to 2cfe9bf Compare January 12, 2022 14:56
Using debug/elf is better on all fronts: faster, simpler, no external deps.
We already use this $ convention for syscall variant names.
Use the same convention for struct.
Currently syz-check supports '_' for structs, but it's
inconsistent with syscalls and leads to ambiguity.
If we enable the same matching for all structs (not just netlink),
then '_' creates lots of false matches. E.g. bpf_link_get_next_id_args
is matches with internal bpf_link struct.
@dvyukov dvyukov force-pushed the dvyukov-syz-check-update branch 2 times, most recently from 929cf89 to 306811c Compare January 13, 2022 10:06
Mention issue with DWARF4+ and bitfields.
Mention kernel configs that must be used for kernel builds.
Regenerate warn files on the latest kernel commit fe8152b38d3
and latest syzkaller commit with fresh kernel config files.
They are not really structs in the kernel even if we describe them as structs.
@dvyukov dvyukov force-pushed the dvyukov-syz-check-update branch from 306811c to a1d1645 Compare January 13, 2022 14:20
@dvyukov dvyukov force-pushed the master branch 3 times, most recently from 67c4a15 to 44b3384 Compare January 28, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants