New goal set-git-properties #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
|
Hi @rhierlmeier & @bvarner , I noticed when building this project using JDK11 I got the following warning while running the JUnit tests:
When looking at https://openjdk.org/jeps/372 , it is clear that modern JDK versions no longer have this scripting capability. In order for this new feature to be used with modern JDKs, I think an alternative for the ScriptEngine should be sought. |
|
It replaced with #139 Javascript with Groovy. |
Nice to see you only needed to swap the scripting language in the test! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the goal set-git-properties that provides information about the branch name and type to the Maven build.
In implements the feature request #131.