feat(js-sdk,py-sdk): Rename rootDir/rootdir to cwd, add cwd option to…

… Session (#165) Co-authored-by: Jakub Novák <[email protected]>
e2b-dev · Sep 27, 2023 · e250a7b · e250a7b
1 parent 522079c
commit e250a7b
Show file tree

Hide file tree

Showing 25 changed files with 185 additions and 314 deletions.
diff --git a/.changeset/sixty-pugs-jog.md b/.changeset/sixty-pugs-jog.md
@@ -0,0 +1,7 @@
+---
+'@e2b/python-sdk': minor
+'@e2b/sdk': minor
+---
+
+Renamed process.start argument rootDir to cwd
+Added cwd option to Session creation
diff --git a/.github/workflows/js_sdk_compat_tests.yml b/.github/workflows/js_sdk_compat_tests.yml
@@ -30,6 +30,8 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
 
+      - uses: pnpm/action-setup@v2   
+
       - name: Setup Node
         uses: actions/setup-node@v3
         with:

diff --git a/apps/docs/src/app/old-page.mdx b/apps/docs/src/app/old-page.mdx
diff --git a/apps/docs/src/code/js/agents/clone_repo.js b/apps/docs/src/code/js/agents/clone_repo.js
@@ -24,7 +24,7 @@ console.log(content)
 console.log('Installing deps...')
 proc = await session.process.start({
   cmd: 'npm install',
-  rootdir: '/code/open-react-template',
+  cwd: '/code/open-react-template',
   onStdout: data => console.log(data.line),
   onStderr: data => console.log(data.line),
 })

diff --git a/apps/docs/src/code/js/agents/install_deps_npm.js b/apps/docs/src/code/js/agents/install_deps_npm.js
@@ -12,7 +12,7 @@ const session = await Session.create({
 console.log('Installing lodash...')
 const proc = await session.process.start({
   cmd: 'npm install lodash', // $HighlightLine
-  rootdir: '/code', // $HighlightLine
+  cwd: '/code', // $HighlightLine
   onStdout: (data) => console.log('[INFO] ', data.line),
   onStderr: (data) => console.log('[WARN | ERROR] ', data.line),
 })

diff --git a/apps/docs/src/code/python/agents/clone_repo.py b/apps/docs/src/code/python/agents/clone_repo.py
@@ -34,11 +34,11 @@ async def main():
     cmd="npm install",
     on_stdout=print_out,
     on_stderr=print_out,
-    rootdir="/code/open-react-template"
+    cwd="/code/open-react-template"
   )
 
   await proc
 
   await session.close()
 
-asyncio.run(main())
+asyncio.run(main())
diff --git a/apps/docs/src/components/Code.tsx b/apps/docs/src/components/Code.tsx
@@ -130,7 +130,7 @@ function CodePanel({
       await session.filesystem.write(filename, code)
       session.process.start({
         cmd: `${runtime} ${filename}`,
-        rootdir: '/code',
+        cwd: '/code',
         onStdout: appendOutput,
         onStderr: filterAndMaybeAppendOutput,
         onExit: () => setIsRunning(false),

diff --git a/apps/docs/src/utils/useSessions.tsx b/apps/docs/src/utils/useSessions.tsx
@@ -66,7 +66,7 @@ export const useSessionsStore = create<SessionsStore>((set, get) => ({
             cmd: preps[lang],
             onStdout: stdHandler,
             onStderr: stdHandler,
-            rootdir: '/code',
+            cwd: '/code',
           })
           await proc.finished // await prep process to finish
           log(`${lang} session created and started`)