-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto pause on timeout to SDK #568
base: add-pause-and-resume-to-sdk-e2b-1190
Are you sure you want to change the base?
Add auto pause on timeout to SDK #568
Conversation
|
d319ba9
to
7c0b99f
Compare
7c0b99f
to
f2ebc1a
Compare
f2ebc1a
to
2a8732e
Compare
0443e7b
to
7a61bda
Compare
Changes the following
autoPause: true
andauto_pause=True
resume
withconnect
SDK Change
The autoPause option is required, and has to be set to true.
JS
Python - Async
Python - Sync
For both Python implementations, the exit now calls .pause() instead of .kill()
Tasks
Update web documentation(not for now, until we know the final SDK DX)Temporary solution for connect
There is a setTimeout for every connect to resolve issues where paused sandbox can immediately timeout.
Options discussed:
1. No set - never sure how long the sandbox will be running
2. Always set the timeout in code - the user can't just connect to the sandbox
without changing the timeout, round trip to the server time
3. Set the timeout in resume on backend - side effect on error
4. Create new endpoint for connect