fakecgo: C functions require nosplit #295
Merged
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakecgo runs on systemstack so we shouldn't ever split the stack. I also updated the size of sigset_t to be the correct size based on the headers. This was needed to make it possible to build with inlining disabled when nosplit was added. Fixes ebitengine#287
hajimehoshi
reviewed
Jan 4, 2025
internal/fakecgo/libcgo.go
Outdated
| // Sources: | ||
| // Darwin - https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/sys/_types.h#L74 | ||
| // FreeBSD - https://github.com/DoctorWkt/xv6-freebsd/blob/d2a294c2a984baed27676068b15ed9a29b06ab6f/include/signal.h#L98C9-L98C21 | ||
| sigset_t [32]byte |
There was a problem hiding this comment.
Ahh it is 128 bytes. Not sure what to do since if it's 128 then it's too big to build when inlining is disabled. I guess inline the functions by hand but that's kind of ugly.
github.com/ebitengine/purego/internal/fakecgo.x_cgo_thread_start: nosplit stack over 792 byte limit
github.com/ebitengine/purego/internal/fakecgo.x_cgo_thread_start<1>
grows 160 bytes, calls github.com/ebitengine/purego/internal/fakecgo._cgo_sys_thread_start<1>
grows 400 bytes, calls github.com/ebitengine/purego/internal/fakecgo._cgo_try_pthread_create<1>
grows 112 bytes, calls github.com/ebitengine/purego/internal/fakecgo.pthread_create<1>
grows 128 bytes, calls github.com/ebitengine/purego/internal/fakecgo.call5<0>
grows 16 bytes, calls indirect
grows 0 bytes, calls runtime.morestack<0>
24 bytes over limit
grows 112 bytes, calls github.com/ebitengine/purego/internal/fakecgo.nanosleep<1>
grows 112 bytes, calls github.com/ebitengine/purego/internal/fakecgo.call5<0>
grows 16 bytes, calls indirect
grows 0 bytes, calls runtime.morestack<0>
8 bytes over limit
hajimehoshi
reviewed
Jan 5, 2025
hajimehoshi
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fakecgo: C functions require nosplit fakecgo runs on systemstack so we shouldn't ever split the stack. Fixes #287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakecgo runs on the system stack so we shouldn't ever split the stack.
I also updated the size of sigset_t to be the correct size based on the headers. This was needed to make it possible to build with inlining disabled when nosplit was added.
Fixes #287