Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2023 Improve error messages #2127

Conversation

elBoberido
Copy link
Member

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

This PR adds the errno to the error message in the default case in the error translation switch statement. In addition it explicitly prints error messages for invalid file descriptors.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the technical debt unclean code and design flaws label Dec 6, 2023
@elBoberido elBoberido self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2127 (9777635) into master (efe0200) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
- Coverage   80.33%   80.27%   -0.06%     
==========================================
  Files         417      417              
  Lines       16142    16151       +9     
  Branches     2252     2252              
==========================================
- Hits        12967    12965       -2     
- Misses       2381     2391      +10     
- Partials      794      795       +1     
Flag Coverage Δ
unittests 80.06% <0.00%> (-0.06%) ⬇️
unittests_timing 15.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../posix/design/source/file_management_interface.cpp 27.38% <0.00%> (-3.29%) ⬇️

... and 1 file with indirect coverage changes

@elBoberido
Copy link
Member Author

Closed in favor of #2129

@elBoberido elBoberido closed this Dec 8, 2023
@elBoberido elBoberido deleted the iox-2023-improve-error-messages branch January 28, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant