iox-#2137 Merge 'ListenerImpl' back to 'Listener'

[elBoberido]

Pre-Review Checklist for the PR Author

1. Add a second reviewer for complex new features or larger refactorings
2. Code follows the coding style of CONTRIBUTING.md
3. Tests follow the best practice for testing
4. Changelog updated in the unreleased section including API breaking changes
5. Branch follows the naming format (iox-123-this-is-a-branch)
6. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
7. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
8. Relevant issues are linked
9. Add sensible notes for the reviewer
10. All checks have passed (except task-list-completed)
11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
12. Assign PR to reviewer

Notes for Reviewer

Once we tried to fix an issue with compile time defined sizes of the Listener in the C binding by splitting the Listener into two classes. This did not fix the problem but we forgot to unify those classes again and ListenerImpl is not meant to be used on its own. This PRs reverts the split and unifies the code into one class.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Bug in 'ListenerImpl' #2137

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (154b5a5) 80.22% compared to head (ecf8bf3) 80.22%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
- Coverage   80.22%   80.22%   -0.01%     
==========================================
  Files         418      418              
  Lines       16172    16168       -4     
  Branches     2255     2255              
==========================================
- Hits        12974    12970       -4     
  Misses       2399     2399              
  Partials      799      799              

Flag	Coverage Δ
unittests	80.00% <88.23%> (-0.01%)	⬇️
unittests_timing	15.25% <78.43%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...sh/include/iceoryx_posh/internal/popo/listener.inl	100.00% <100.00%> (+5.12%)	⬆️
...ceoryx_posh/include/iceoryx_posh/popo/listener.hpp	0.00% <ø> (ø)
iceoryx_posh/source/popo/listener.cpp	90.78% <89.74%> (-1.52%)	⬇️

[elBoberido]

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @budrus @elfenpiff feel free to add yourself as reviewer

[mossmaurice]

LGTM, thanks for the PR! Merry Christmas! 🎄 🎅