Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not dataAddrPtr assert in arraycopyEval for dstObj #20480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmnattas
Copy link
Contributor

@rmnattas rmnattas commented Nov 1, 2024

For offheap, the arraycopy transformations uses the correct base object in the dstObj node instead of the dataAddrPtr load. To guard that asserts are added to check the dstObj node to not be a dataAddrPtr symbol.

Following: #20264
OMR version: eclipse-omr/omr#7500

TODO:

is it possible that optimizer transformed the arrayCopy tree to such an extent that secondChild doesn't have children anymore (for example, it is an aRegLoad or something like that)? two obvious problems: 1) is it still having isDataAddrPointer flag set? 2) getFirstChild will have or cause problems.
This comment is applicable to all files modified.

Idea is to check if node is marked as internal-pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant