Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(sumo): Fix call of adjustToSumoTimeStep #327

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

schwepmo
Copy link
Contributor

@schwepmo schwepmo commented Jul 6, 2023

Description

  • this PR reverts a regression that happened during a refactor and would lead to the issue described in Scheduled event lies in the past #326
  • it was fixed by calling adjustToSumoTimeStep with the configured update interval as nanoseconds instead of milliseconds (i.e., sumoConfig.updateInterval * TIME.MILLI_SECOND)

What is this PR about?

Issue(s) related to this PR

  • solves internal issue 629

  • Resolves issue # / internal issue

Affected parts of the online documentation

  • no changes required

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

…erval as nano second

* additionally reworked tests to use nanoseconds
* added a test cas in SumoAmbassador test which would fail with old method call

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo schwepmo added the bugfix Pull requests that fixes a bug label Jul 6, 2023
@schwepmo schwepmo requested a review from kschrab July 6, 2023 13:57
@kschrab kschrab merged commit d39c34a into main Jul 11, 2023
1 check passed
@kschrab kschrab deleted the 629-bugfix-vehicle-speed-change branch July 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants