Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mapping): decel was missed when creating a vehicle type #337

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Jul 31, 2023

Description

When decel was configured in the types section of either a vehicle or matrixMapper, it was missed when the corresponding VehicleType was created. See discussion #336 .

This is now fixed and a test has been added to check all currently existing fields

Issue(s) related to this PR

Affected parts of the online documentation

Changes in the documentation required?

No

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab added the bugfix Pull requests that fixes a bug label Jul 31, 2023
@kschrab kschrab requested a review from schwepmo July 31, 2023 16:46
@schwepmo
Copy link
Contributor

schwepmo commented Aug 1, 2023

From my side the changes look fine, however this PR is still a draft so if there are no further changes feel free to "un-draft" it and pull the changes

@kschrab kschrab marked this pull request as ready for review August 1, 2023 06:50
@schwepmo schwepmo merged commit b184d3f into main Aug 1, 2023
1 check passed
@kschrab kschrab deleted the 336-fix-type-decel branch August 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants