Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Java 11 as compiler target #341

Merged
merged 5 commits into from
Aug 11, 2023
Merged

feat: use Java 11 as compiler target #341

merged 5 commits into from
Aug 11, 2023

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Aug 9, 2023

Description

Due to the increase of components which are compiled with JDK version 11, we finally take the step and migrate to Java 11, too. Since we were already compatible to Java 11 during runtime, no code had to be adjusted. From now on, we furthermore can take advantage of new Java 11 features, such as var keyword for local variables or additional String methods.

Issue(s) related to this PR

  • Resolves internal issue 640

Affected parts of the online documentation

There are many parts in our online documentation which need to be adjusted with the next release.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab changed the title feat: Use Java 11 as compiler target feat: use Java 11 as compiler target Aug 9, 2023
Signed-off-by: Karl Schrab <[email protected]>
@kschrab kschrab added the enhancement New feature or request label Aug 9, 2023
Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything works on Jenkins and the changes are really minor, I think we can merge this.
We should however create an issue for the changes in the documentation.

@schwepmo schwepmo merged commit 8eef354 into main Aug 11, 2023
3 checks passed
@rprotzmann rprotzmann deleted the 640-jdk-11 branch August 21, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants