Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scenario-database): Fixed database type affinities #342

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

schwepmo
Copy link
Contributor

@schwepmo schwepmo commented Aug 11, 2023

Description

  • While handling different SUMO edge names it became apparent that sometimes names would be treated as REALs, this was due to the usage of the non-existent affinity STRING
  • This PR changes all affiliations to valid or default affinity values
    • STRING -> TEXT
    • DOUBLE -> REAL
  • this has the unfortunate side-effect that the scenario databases will be a little bit larger in size, but I believe we don't need to re-create old databases anyhow so this will only affect future scenarios

Issue(s) related to this PR

  • resolves internal issue 654

Affected parts of the online documentation

  • No changes required

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@schwepmo schwepmo requested a review from kschrab August 11, 2023 08:47
@kschrab kschrab added the bugfix Pull requests that fixes a bug label Aug 11, 2023
@schwepmo schwepmo assigned rprotzmann and schwepmo and unassigned schwepmo Aug 14, 2023
@rprotzmann rprotzmann merged commit 8f038ca into main Aug 21, 2023
1 check passed
@rprotzmann rprotzmann deleted the 654-fix-sqlite-affinities branch August 21, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants