feat(interaction): Added LidarUpdates interaction and LidarData object #391
Conversation
|
|
||
| import javax.annotation.Nonnull; | ||
|
|
||
| public interface LidarApplication extends Application { |
There was a problem hiding this comment.
This class needs to be documented before being merged.
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class LidarUpdates extends Interaction { |
There was a problem hiding this comment.
This class needs some more documentation before being merged
|
|
||
|
|
||
|
|
||
| public LidarUpdates(long time, List<LidarData> updated) { |
There was a problem hiding this comment.
For me it isn't clear what exactly the list of updated LidarData is made-up of.
- Is it lidar data for all ego-vehicles at
time? - Is it lidar data for one ego-vehicle at
time?
This kind of stuff should be documented.
As far as I get, each ego-vehicle has a LidarData-Object for each lidar-collection-time, which contains the measured point clouds, right?
| private final Object lidarData; | ||
|
|
||
| private final long time; | ||
| private final String name; |
There was a problem hiding this comment.
Document the fields and maybe rename name to vehicleId or something that better describes it.
|
|
||
| public class LidarData implements Serializable { | ||
| @JsonAdapter(PolymorphismTypeAdapterFactory.class) | ||
| private final Object lidarData; |
There was a problem hiding this comment.
Why is this an Object and why is it called lidarData inside of the LidarData-class? This adds unnecessary confusion.
Do we not have a class representing the point clouds instead of using a generic object?
…habmacs may be nice
Description
What is this PR about?
Related to
Affected parts of the online documentation
I believe no change in online documentation are required.
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer