Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(checkstyle): bumped checkstyle version to 10.15.0 #392

Merged
merged 11 commits into from
Jul 3, 2024
Merged

chore(checkstyle): bumped checkstyle version to 10.15.0 #392

merged 11 commits into from
Jul 3, 2024

Conversation

schwepmo
Copy link
Contributor

Description

  • done to support intelliJ checkstyle plugin
  • some adjustments in the configuration were required due to version changes

What is this PR about?

Issue(s) related to this PR

  • Resolves issue internal issue 845

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@schwepmo
chore(checkstyle): bumped checkstyle version to 10.15.0
35727a5 
* done to support intelliJ checkstyle plugin
* some adjustments in the configuration were required due to version changes

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo schwepmo self-assigned this May 29, 2024
@schwepmo schwepmo requested a review from kschrab May 29, 2024 14:38
@schwepmo schwepmo added chore Pull request that resolve around a chore dependencies Pull requests that update a dependency file labels May 29, 2024
@schwepmo
chore(checkstyle): working on checkstyle issues
86da604 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): set validateThrows to false (see http://www.javapr…
91064b0 
…actices.com/topic/TopicAction.do?Id=171)

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): added further valid abbreviations
c085a89 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): getting rid of more checkstyle warnings
2e2c230 
* cleaned SQLiteWriter
* cleaned ClientServerChannel
* cleaned IPResolver
* documented Vector3d class

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): cleaned ClientServerChannel
0617e16 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): added SuppressWarnings module so checkstyle warnin…
4f523fe 
…gs can be suppressed if necessary

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): updated SuppressWarnings module
1c43c53 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): fixing some further checkstyle warnings
dba1238 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): configured checkstyle to be able to suppress check…
95c9da2 
…style warnings (See SuppressWarningsHolder)

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo
chore(checkstyle): ignore naming in conventions in Wgs84Projection
e48908a 
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@kschrab kschrab merged commit f1f0682 into main Jul 3, 2024
6 checks passed
@kschrab kschrab deleted the 845-update-checkstyle branch July 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschrab kschrab kschrab approved these changes

Assignees

@schwepmo schwepmo

Labels
chore Pull request that resolve around a chore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwepmo @kschrab