Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geomath): introduce class for point cloud #401

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Aug 8, 2024

Description

Adds a new class representing a Point Cloud. This class can serve as a future common class between PHABMACS or CARLA (producers of point clouds) and MOSAIC Application (consumer).

  • Based on the class LidarFrame, which is currently placed in the PHABMACS simulator.
  • PointCloud itself is abstract, and must be created using the inner implementations Relative or Absolute, depending on the format of the hit points (either in absolute or relative coordinates).
  • PointCloud contains single points based on Vector3d coordinates. Each Point has additional fields distance (distrance to origin of point cloud) and hitType (type of object being hit by the ray which produced the point, with 0 = no hit).

Issue(s) related to this PR

  • Resolves internal issue 868

Affected parts of the online documentation

Changes in the documentation required?

No

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab self-assigned this Aug 8, 2024
@kschrab kschrab added the enhancement New feature or request label Aug 9, 2024
@schwepmo schwepmo self-requested a review August 14, 2024 09:00
@schwepmo schwepmo merged commit 271ef0d into main Aug 14, 2024
5 of 6 checks passed
@schwepmo schwepmo deleted the 868-point-cloud branch August 14, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants