Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved EdgeFinder in cases where adjacent connections share the same FROM and TO points #405

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

schwepmo
Copy link
Contributor

@schwepmo schwepmo commented Sep 2, 2024

Description

  • When using findClosestRoadPosition(GeoPoint geoPoint) ambiguities can arise if adjacent connections share the same FROM and TO nodes in opposite directions
  • since we don't store information about the geometry of lanes, both edges can be a valid return and it depends on the KD-Tree, which edge is returned
  • Additionally, a signature using the heading as a similarity measure for matching edges has been added to the EdgeFinder and has been propagated to the Routing and IRoutingModule interfaces
  • I'm not sure what happens if two edges directly overlap

Issue(s) related to this PR

  • Resolves internal issue 880

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

…e same FROM and TO points

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo schwepmo added the bugfix Pull requests that fixes a bug label Sep 2, 2024
@schwepmo schwepmo self-assigned this Sep 2, 2024
…es a heading now

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
… and IRoutingModule interfaces

Signed-off-by: Moritz Schweppenhäuser <[email protected]>
@schwepmo schwepmo merged commit 32656de into main Sep 5, 2024
6 checks passed
@schwepmo schwepmo deleted the 880-improve-closest-edge branch September 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants