Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tutorial): WeatherServerApp now relays the last received DENM #408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hoelger
Copy link

@hoelger hoelger commented Sep 6, 2024

Description

The all-knowing weather server sends out warnings from second one. So any cell device will omit the icy region from the beginning on, and not a single cell-car will go towards the icy region.
I think it's more realistic, that the server can just relay the warnings that it received by cars.
For simplicity of the tutorial, the server will just memorize the last warning, and relay this last warning, independent from which car and from where it was sent.

Issue(s) related to this PR

  • Resolves internal issue 887

Affected parts of the online documentation

  • Changes in the documentation required!

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab
Copy link
Contributor

kschrab commented Sep 9, 2024

Please fill the description template. I guess you'd need to update BarnimReleaseIT as well.

@kschrab kschrab self-requested a review September 9, 2024 07:44
@kschrab kschrab changed the title feat: The WeatherServerApp now relays the last received DENM feat(tutorial): WeatherServerApp now relays the last received DENM Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants