Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorial): tiny improvements on weather warning application #409

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Sep 11, 2024

Description

Small fixes that arose when getting familiar with MOSAIC

Issue(s) related to this PR

  • Resolves internal issue 885

Affected parts of the online documentation

Changes in the documentation required? No.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@hoelger
Copy link
Contributor Author

hoelger commented Sep 11, 2024

First finish the discussions in issue 885 and look if more code changes come up, then review and merge this PR

@kschrab kschrab changed the title fix: tiny improvements fix(tutorial): tiny improvements on weather warning application Sep 13, 2024
@kschrab
Copy link
Contributor

kschrab commented Sep 16, 2024

@hoelger continuous integration was not successful, check BarnimReleaseIT

@hoelger hoelger force-pushed the 885-get-familiar-with-mosaic-fixes branch 3 times, most recently from 4c35138 to 80d55b5 Compare September 30, 2024 15:25
@hoelger hoelger force-pushed the 885-get-familiar-with-mosaic-fixes branch from 80d55b5 to 5b29952 Compare September 30, 2024 16:48
@kschrab kschrab merged commit 290fa8d into eclipse:main Oct 1, 2024
5 checks passed
@hoelger hoelger deleted the 885-get-familiar-with-mosaic-fixes branch October 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants