Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Accelerate Unsafe CAS Intrinsics on Power and X #7438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Accelerate Unsafe CAS Intrinsics on Power and X #7438

wants to merge 1 commit into from

Conversation

IBMJimmyk
Copy link
Contributor

@IBMJimmyk IBMJimmyk commented Aug 12, 2024 •
edited
Loading

Adds lbarx, lharx, stbcx_r and sthcx_r instruction support for Power. These instructions are not currently in use but will be needed for future enhancements targetting CAS on byte and short length data.

Updates willBeEvaluatedAsCallByCodeGen to reflect the new acceleration of Unsafe compareAndExchange methods on X.

Edit:
X changes are dependent on this OpenJ9 PR:
eclipse-openj9/openj9#19991
Behavior of inlineCompareAndSwapNative and inlineCompareAndSwapObjectNative in J9TreeEvaluator.cpp must match behavior in willBeEvaluatedAsCallByCodeGen in OMRCodeGenerator.cpp

@IBMJimmyk IBMJimmyk mentioned this pull request Aug 12, 2024
Open
@IBMJimmyk
Copy link
Contributor Author

@hzongaro The compiler/x/codegen/OMRCodeGenerator.cpp change goes along with the OpenJ9 changes for accelerating Unsafe CAS on X and unfortunately is inside OMR instead of OpenJ9. I also need to double check if the change to callDoesAnImplicitAsyncCheck is correct.

@zlwang I need a review on the Power instructions being added.

Also, would it be preferred if this PR was split into two? I was working on the Power and X accelerations at the same time and the end result just happened to be 2 fairly disjoint changes to OMR.

hzongaro
hzongaro approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes for x/codegen/OMRCodeGenerator.cpp and compiler/optimizer/RedundantAsyncCheckRemoval.cpp look correct.

@IBMJimmyk
Copy link
Contributor Author

@zlwang did you get a chance to look over these changes?

zl-wang
zl-wang approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IBMJimmyk
Accelerate Unsafe CAS Intrinsics on Power and X
df7fc8c 
Adds lbarx, lharx, stbcx_r and sthcx_r instruction support for Power. These
instructions are not currently in use but will be needed for future
enhancements targetting CAS on byte and short length data.

Updates willBeEvaluatedAsCallByCodeGen to reflect the new acceleration of
Unsafe compareAndExchange methods on X.

Signed-off-by: jimmyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@zl-wang zl-wang zl-wang approved these changes

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees
No one assigned
Labels
arch:power arch:x86 comp:compiler comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IBMJimmyk @hzongaro @zl-wang