Support IEEE-754 w.r.t fmin/fmax/dmin/dmax #7464
Draft
+146
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
commented
Sep 18, 2024
•
matthewhall2
commented
- Enables inlining of fmin/fmax/dmin/dmax nodes
- Implements IEEE-754 standard for the evaluators:
- if the first arg is a NaN, returns the corresponding quiet NaN, same for if only the second arg is a NaN
- Uses vector operations when available, defaults to branching if not
- Supports inlining for Support java behaviour w.r.t fmin/fmax/dmin/dmax eclipse-openj9/openj9#20185
Add Math.max/min/F/D to list of recognized Java methods to: - Disable special aliasing rules since they are intrinsically optimized - Disable implicit asynchronous checks Signed-off-by: Sarwat Shaheen <[email protected]>
Refactor the S390 MaxMin evaluator to support Java specifications: - support the treatment of negative zero - float and double max/min calls consider -0 to be strictly smaller +0 Signed-off-by: Sarwat Shaheen <[email protected]>
matthewhall2
force-pushed
the
fmin_fmax_dmin_dmax
branch
from
2ea04da
to
88e0beb
Compare
…rted - Use load and test in swap region to set quiet bit Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
fmin_fmax_dmin_dmax
branch
from
88e0beb
to
65d97f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.