Move app details to main AuthAdminState #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use these details in several places around the app now, so we should read and write the new values from the main `AuthConfig` object. Note: the old app details in the `UIConfig` still exist, but we should consider them deprecated and ignore the existing values there.
|
This looks good, except the ui is also used in the cloud, where it could be used with a 4.x version of edgedb, so we need to keep both forms and conditionally show one depending on the version. Also it would probably be better to have a single set of form update/clear buttons like the smtp config, but I can work on these changes. |
…update buttons for core config ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use these details in several places around the app now, so we should read and write the new values from the main
AuthConfigobject.Note: the old app details in the
UIConfigstill exist, but we should consider them deprecated and ignore the existing values there.As far as a deployment plan goes, I'm not sure how to make sure this gets sequenced correctly. It should only be merged once the server change that it depends on is merged, and it should not be backported to 4.x. I mostly did this work so I can actually test the server change, so apologies for the weird sequencing here.