Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand coordinator store interface #1237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expand coordinator store interface #1237

wants to merge 2 commits into from

Conversation

davidweisse
Copy link
Contributor

This adds the Watch() function to the Store interface of the Coordinator. The signature is similar to K8s watchers, and it returns a Watcher interface, like watch.Interface.

The NewStore() method is separated and brought to a new file, so it can be controlled via a no-enterprise build tag.

@davidweisse davidweisse added the no changelog PRs not listed in the release notes label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgerdev burgerdev Awaiting requested review from burgerdev burgerdev is a code owner

@katexochen katexochen Awaiting requested review from katexochen katexochen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidweisse