Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ALLOW_DUPLICATE_CORNERS #672

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Add ALLOW_DUPLICATE_CORNERS #672

wants to merge 6 commits into from
+84 −20

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Feb 19, 2025 •
edited
Loading

Fixes #668

@kareefardi
add CORNERS_ALLOW_DUPLICATE
d888dfb 
load libs in the same order of defining corners

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
define_corners in the same order too
83c6ee0 
Signed-off-by: Kareem Farid <[email protected]>
@openlane-bot
Copy link
Collaborator

openlane-bot commented Feb 19, 2025 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/5a9f0a1a5944ae7ba50181e3414e7ee0

@kareefardi kareefardi changed the title add CORNERS_ALLOW_DUPLICATE Add ALLOW_DUPLICATE_CORNERS Feb 23, 2025
@kareefardi kareefardi marked this pull request as ready for review February 23, 2025 10:44
@kareefardi kareefardi requested a review from donn February 23, 2025 10:44
donn
donn reviewed Feb 23, 2025
View reviewed changes
Changelog.md
* Added `PNR_CORNERS` which defaults to `STA_CORNERS`. An override for
`DEFAULT_CORNER` for PnR steps except for steps using `RSZ_CORNERS` and
`CTS_CORNERS`.
* Added `ALLOW_DUPLICATE_CORNERS` to avoid redundant corners definitions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain what it does in more detail.

@kareefardi
enhance changelog description
b42f7ae 
Signed-off-by: Kareem Farid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kareefardi @openlane-bot @donn