Change AdaptiveHandler::write() argument type and update monolog/monolog requirement #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the newrelic bundle on Symfony 6.2 and PHP 8.1 I get the following error:
Since monolog/monolog
v3.0.0
the argument type was changed fromarray
toLogRecord
(see: https://github.com/Seldaek/monolog/blame/main/src/Monolog/Handler/NewRelicHandler.php#L60).I updated the argument type, as well as the required version of
monolog/monolog
since the need to be compatible, it requires versionv3.0.0
.Note I also reviewed that PR #281 but I introduce less changes in the hope to fix that specific issue.